-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented proof rerandomization #16
Conversation
Thanks for the PR! Do you have a link to the paper that proposes this randomization? It would be good to add this link to the comments. |
Thanks for the new feature, and for making the tests test across multiple curves! |
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for upstreaming it
It's noticeably faster to create a non-zk proof and then rerandomize it afterwards. |
I need this functionality for a project I'm working on, and I figured it fits well into upstream. I also cleaned up the testing procedures.